From 576dd2e35e3432129ad1002ba0455eb82eb9a52d Mon Sep 17 00:00:00 2001 From: itsMapleLeaf <19603573+itsMapleLeaf@users.noreply.github.com> Date: Wed, 27 Sep 2023 13:29:20 -0500 Subject: [PATCH] manual fixes, disable some errors --- package.json | 6 +++++- packages/helpers/retry-with-timeout.ts | 2 +- packages/helpers/wait-for.ts | 1 + packages/reacord/library/core/reacord-discord-js.ts | 2 ++ packages/reacord/scripts/discordjs-manual-test.tsx | 2 +- packages/website/src/components/landing-animation.tsx | 2 ++ 6 files changed, 12 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 272c05d..10a5252 100644 --- a/package.json +++ b/package.json @@ -38,6 +38,10 @@ "node_modules", "dist", "packages/website/public/api" - ] + ], + "rules": { + "@typescript-eslint/no-non-null-assertion": "warn", + "@typescript-eslint/require-await": "off" + } } } diff --git a/packages/helpers/retry-with-timeout.ts b/packages/helpers/retry-with-timeout.ts index a40d455..f2c3e46 100644 --- a/packages/helpers/retry-with-timeout.ts +++ b/packages/helpers/retry-with-timeout.ts @@ -7,7 +7,7 @@ export async function retryWithTimeout( callback: () => Promise | T, ): Promise { const startTime = Date.now() - // eslint-disable-next-line no-constant-condition + // eslint-disable-next-line no-constant-condition, @typescript-eslint/no-unnecessary-condition while (true) { try { return await callback() diff --git a/packages/helpers/wait-for.ts b/packages/helpers/wait-for.ts index f34e7c3..7f8336e 100644 --- a/packages/helpers/wait-for.ts +++ b/packages/helpers/wait-for.ts @@ -18,5 +18,6 @@ export async function waitFor( } } + // eslint-disable-next-line @typescript-eslint/no-throw-literal throw lastError ?? new Error("Timeout") } diff --git a/packages/reacord/library/core/reacord-discord-js.ts b/packages/reacord/library/core/reacord-discord-js.ts index 15d4ba1..382b913 100644 --- a/packages/reacord/library/core/reacord-discord-js.ts +++ b/packages/reacord/library/core/reacord-discord-js.ts @@ -374,6 +374,8 @@ function getDiscordMessageOptions(reacordOptions: MessageOptions) { } } + // future proofing + // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition if (component.type === "select") { return { ...component, diff --git a/packages/reacord/scripts/discordjs-manual-test.tsx b/packages/reacord/scripts/discordjs-manual-test.tsx index cc248e0..96cbf39 100644 --- a/packages/reacord/scripts/discordjs-manual-test.tsx +++ b/packages/reacord/scripts/discordjs-manual-test.tsx @@ -34,7 +34,7 @@ for (const [, channel] of category.children.cache) { let prefix = 0 const createTest = async ( name: string, - block: (channel: TextChannel) => void | Promise, + block: (channel: TextChannel) => unknown, ) => { prefix += 1 const channel = await category.children.create({ diff --git a/packages/website/src/components/landing-animation.tsx b/packages/website/src/components/landing-animation.tsx index a8caad2..0fc632f 100644 --- a/packages/website/src/components/landing-animation.tsx +++ b/packages/website/src/components/landing-animation.tsx @@ -35,6 +35,7 @@ export function LandingAnimation() { let running = true void (async () => { + // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition while (running) { setState(defaultState) await delay(700) @@ -102,6 +103,7 @@ export function LandingAnimation() { let running = true void (async () => { + // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition while (running) { // check if the cursor is in the input const cursorRect = cursorRef.current!.getBoundingClientRect()